Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split console logs and actual logs and add a banner :) #1037

Merged
merged 1 commit into from
Nov 13, 2020

Conversation

dadoonet
Copy link
Owner

@dadoonet dadoonet commented Nov 9, 2020

Simplify log4j2.xml for the end user. Now you can control where FSCrawler will store the logs and the log levels by setting LOG_DIR, LOG_LEVEL and DOC_LEVEL Java properties.

FS_JAVA_OPTS="-DLOG_DIR=path/to/logs_dir -DLOG_LEVEL=trace -DDOC_LEVEL=debug" bin/fscrawler

In the future we might remove the --debug and --trace CLI options.

Also adds a banner! :)

Follow up for #1031

Simplify `log4j2.xml` for the end user. Now you can control where FSCrawler will store the logs and the log levels by setting `LOG_DIR`, `LOG_LEVEL` and `DOC_LEVEL` Java properties.

```sh
   FS_JAVA_OPTS="-DLOG_DIR=path/to/logs_dir -DLOG_LEVEL=trace -DDOC_LEVEL=debug" bin/fscrawler
```

In the future we might remove the `--debug` and `--trace` CLI options.

Also adds a banner! :)

Follow up for #1031
@dadoonet dadoonet added the new For new features or options label Nov 9, 2020
@dadoonet dadoonet added this to the 2.7 milestone Nov 9, 2020
@dadoonet dadoonet self-assigned this Nov 9, 2020
@sonarcloud
Copy link

sonarcloud bot commented Nov 13, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 5 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it accepting it soon.Please update to at least Java 11.
Read more here

@dadoonet dadoonet merged commit 1d84d9f into master Nov 13, 2020
@dadoonet dadoonet deleted the pr/log-index-errors branch November 13, 2020 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new For new features or options
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant