Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid requesting client proxy cert if not needed #181

Open
cal-jlab opened this issue Jul 2, 2024 · 2 comments
Open

Avoid requesting client proxy cert if not needed #181

cal-jlab opened this issue Jul 2, 2024 · 2 comments

Comments

@cal-jlab
Copy link
Contributor

cal-jlab commented Jul 2, 2024

Hi there! I encountered an issue that was preventing me from using xrootd4j as a load-balancer for delegated third-party copies when using GSI authentication. Specifically, the class GSIPost49ServerRequestHandler always requests a proxy certificate from the client if the client is capable of creating one, even if the server has no need for it. Rather than implement the whole X509ProxyDelegationClient interface (and the requisite underpinnings) for no real purpose, I simply disabled the request in a forked copy of xrootd4j. I would offer to contribute some changes to this logic, but it's not clear what would be the correct way to modify the code to make the proxy request optional, as opposed to simply disabling that bit of code.

@kofemann
Copy link
Member

@cal-jlab somehow I miss my earlier comment here...anyway

accorgin GSI standard, the delegation should be requested by client. In case of xroot, this is triggerd by client sending kXGC_certreq. Do you observe different behavior?

@cal-jlab
Copy link
Contributor Author

This is the code I'm talking about. The server always sends the signing request to the client if the client supports it, even if the server has no need for it. This happens in response to kXGC_cert, not kXGC_certreq.

/**
* Only send a sign request to the client if the client supports it.
*/
if (clientCanSignRequest) {
return getSigPxyResponse(certChain, request, mainBucket);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants