Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ellipse() ? #29

Open
nitaku opened this issue Feb 17, 2021 · 6 comments · May be fixed by #32
Open

Add support for ellipse() ? #29

nitaku opened this issue Feb 17, 2021 · 6 comments · May be fixed by #32

Comments

@nitaku
Copy link

nitaku commented Feb 17, 2021

It would be very useful to have support for the ellipse() method.
Specs: https://html.spec.whatwg.org/multipage/canvas.html#dom-context-2d-ellipse

@mbostock
Copy link
Member

Is ellipse new? Doesn’t look like part of CanvasPathMethods:

https://www.w3.org/TR/2dcontext/#canvaspathmethods

@nitaku
Copy link
Author

nitaku commented Feb 17, 2021

I found it in this MDN documentation page, which lead to the HTML Living Standard spec.

I am not 100% sure about the status of these specifications, but the W3C one you mentioned is marked as "superseded". A level 2 spec was in the working, but it seems to be abandoned: https://www.w3.org/TR/2dcontext2/

I tested ellipse() with canvas on Chrome 88. It also seems to be widely adopted, according to https://caniuse.com/mdn-api_canvasrenderingcontext2d_ellipse

@nitaku
Copy link
Author

nitaku commented Feb 17, 2021

I hope it could be a matter of adapting the code to accept two different radii, given that the A command in an SVG path definition already represents an elliptical arc (and providing an ellipse() method, which could be also leveraged by arc()).

@curran
Copy link

curran commented Feb 18, 2021

@nitaku Do you have an idea in mind for what the API could look like?

@nitaku
Copy link
Author

nitaku commented Feb 18, 2021

I would expect this signature for the ellipse method:

ellipse(x, y, radiusX, radiusY, rotation, startAngle, endAngle, counterclockwise)

as described here in more detail: https://html.spec.whatwg.org/multipage/canvas.html#dom-context-2d-ellipse
It would be identical to the ellipse method defined for canvas.

@kleem kleem linked a pull request May 11, 2021 that will close this issue
@nitaku
Copy link
Author

nitaku commented May 11, 2021

We used a few test renderings made with Canvas as a reference.
Here is a CodePen that compares Canvas and SVG renderings made with the modified code: https://codepen.io/nitaku/pen/dyvyGaZ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants