Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where is the vscode-extension-common in package.json dependencies? #3

Closed
vikyd opened this issue Apr 27, 2018 · 3 comments
Closed

Where is the vscode-extension-common in package.json dependencies? #3

vikyd opened this issue Apr 27, 2018 · 3 comments
Labels

Comments

@vikyd
Copy link

vikyd commented Apr 27, 2018

I want to build vscode-extension-fold from source, but missing vscode-extension-common.

@d-akara
Copy link
Owner

d-akara commented Apr 27, 2018

@vikyd it is just a relative file reference in package.json.

So you will want to clone this repository https://github.com/dakaraphi/vscode-extension-common

@vikyd
Copy link
Author

vikyd commented Apr 27, 2018

Why not publish vscode-extension-common to npm?

@d-akara
Copy link
Owner

d-akara commented Apr 27, 2018

I couldn't figure out a workflow that allowed for quick iterations. I often make a lot of small quick changes between multiple plugins sharing this library and publishing to npm for each change would be a pain.

So using npm link should be a solution. However, I ran into issues there as well. Seems almost nobody is working with shared libraries pulling in vscode dependencies as it doesn't work.
These are some of the problems I ran into.
microsoft/TypeScript#6496
microsoft/vscode#25312
microsoft/vscode-vsce#207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants