Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time format match #20

Merged
merged 2 commits into from
Oct 9, 2019
Merged

Conversation

marco-silveira
Copy link
Contributor

The day and time regular expressions verify is those are valid (e.g. days regex only recognize 01 to 31, and time regex only recognize 00:00:00 to 23:59:59).

But no verification is being made on the date (e.g. Feb 31 will be recognized).

Closes #8

@codecov-io
Copy link

codecov-io commented Oct 9, 2019

Codecov Report

Merging #20 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #20   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines          83     87    +4     
=====================================
+ Hits           83     87    +4
Impacted Files Coverage Δ
matcher.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65bc35a...c2a8385. Read the comment docs.

matcher.go Outdated Show resolved Hide resolved
matcher.go Outdated Show resolved Hide resolved
@marco-silveira
Copy link
Contributor Author

♻️ @cyucelen

@cyucelen cyucelen merged commit a68c109 into cyucelen:master Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Match time format
3 participants