Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong UploadedFile URL when deleting after a fetchByAbstractImage #18

Open
geektortoise opened this issue Aug 13, 2020 · 2 comments
Open
Labels
good first issue Good for newcomers

Comments

@geektortoise
Copy link
Contributor

The following code

    UploadedFile uf = UploadedFile.getByAbstractImage(idAbstractImage)
    uf.delete()

doesn't work because the model still have the filter "image" and doesn't return the standard URL
https://github.com/cytomine/Cytomine-java-client/blob/master/src/main/java/be/cytomine/client/models/UploadedFile.java#L176

Solution : in the UploadedFile.java
Remove the image filter at the end of the getByAbstractImage method
or
add condition in the getJSONResourceURL method to apply the filter only for the fetch case.

@geektortoise geektortoise added the good first issue Good for newcomers label Aug 13, 2020
@Umang228
Copy link

Assign this to me. I know how to solve it.

@Umang228
Copy link

I have solved the issue plz merge the PR#22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants