Skip to content

LAMBJ-150 Invalid PhysicalResourceId Error #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 8, 2022
Merged

LAMBJ-150 Invalid PhysicalResourceId Error #480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a958b4
LAMBJ-150 Invalid PhysicalResourceId Error
talenfisher Feb 8, 2022
8080a62
LAMBJ-150 Update Version, Add Release Notes
talenfisher Feb 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/releases/v0.9.2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## Bug Fixes

- Fixes an issue where custom resources would sometimes return an 'Invalid PhysicalResourceId' error.
3 changes: 3 additions & 0 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@
"markdown.extension.toc.levels": "2..6",
"editor.semanticHighlighting.enabled": true,
"csharp.semanticHighlighting.enabled": true,
"files.exclude": {
"**/.nuget": true,
},
"yaml.customTags": [
"!And",
"!And sequence",
Expand Down
2 changes: 1 addition & 1 deletion src/CustomResource/CustomResourceRequest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public class CustomResourceRequest
/// for the requested custom resource.
/// </summary>
/// <value>The physical resource ID of the requested custom resource.</value>
public virtual string PhysicalResourceId { get; set; } = string.Empty;
public virtual string? PhysicalResourceId { get; set; }

/// <summary>
/// Gets or sets the extra properties that appear when deserializing a request to this type.
Expand Down
2 changes: 1 addition & 1 deletion src/CustomResource/CustomResourceResponse.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public class CustomResourceResponse<TResourceOutputData>
/// Gets or sets the physical resource ID of the requested custom resource.
/// </summary>
/// <value>The physical resource ID of the requested custom resource.</value>
public string PhysicalResourceId { get; set; } = string.Empty;
public string? PhysicalResourceId { get; set; }

/// <summary>
/// Gets or sets the ID of the CloudFormation stack the requested custom resource belongs to.
Expand Down
2 changes: 1 addition & 1 deletion version.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"$schema": "https://raw.githubusercontent.com/AArnott/Nerdbank.GitVersioning/master/src/NerdBank.GitVersioning/version.schema.json",
"version": "0.9.1",
"version": "0.9.2",
"publicReleaseRefSpec": [
"^refs/tags/v\\d\\.\\d"
]
Expand Down