chore: Check branch for latest chrome versions, not current chrome versions (#32976)

* Check branch for latest chrome versions, not current chrome versions

* empty commit

* add permissions for pull-requests write for browser version action

* try to just install yarn

* just leave deps actually

* remove adding to project board

* fix mocked requests in test

* cleanup

* move cleanup to afterEach

Author: jennifer-shehane

.github/workflows/update-browser-versions.yml

@@ -7,6 +7,8 @@ on:
 jobs:
   update-browser-versions:
     runs-on: ubuntu-latest
+    permissions:
+      pull-requests: write
     env:
       CYPRESS_BOT_APP_ID: ${{ secrets.CYPRESS_BOT_APP_ID }}
       BASE_BRANCH: develop
@@ -47,7 +49,7 @@ jobs:
       - name: Determine name of new branch and if it already exists
         id: check-branch
         env:
-          BRANCH_NAME: update-chrome-stable-from-${{ steps.get-versions.outputs.current_stable_version }}-beta-from-${{ steps.get-versions.outputs.current_beta_version }}
+          BRANCH_NAME: update-chrome-stable-from-${{ steps.get-versions.outputs.latest_stable_version }}-beta-from-${{ steps.get-versions.outputs.latest_beta_version }}
         run: |
           echo "branch_name=${{ env.BRANCH_NAME }}" >> $GITHUB_OUTPUT
           echo "branch_exists=$(git show-ref --verify --quiet refs/remotes/origin/${{ env.BRANCH_NAME }} && echo 'true')" >> $GITHUB_OUTPUT
@@ -127,5 +129,4 @@ jobs:
               branchName: '${{ steps.check-branch.outputs.branch_name }}',
               description: '${{ steps.get-versions.outputs.description }}',
               body: 'This PR was auto-generated to update the version(s) of Chrome for driver tests',
-              addToProjectBoard: true,
             })

scripts/github-actions/update-browser-versions.js

@@ -1,4 +1,3 @@
-const https = require('https')
 const fs = require('fs')
 const yaml = require('yaml')
 const path = require('path')
@@ -10,33 +9,16 @@ const CHROME_BETA_KEY = 'chrome-beta-version'
 const CIRCLECI_WORKFLOWS_FILEPATH = path.join(__dirname, '../../.circleci/src/pipeline/@pipeline.yml')
 
 // https://developer.chrome.com/docs/versionhistory/reference/#platform-identifiers
-const getLatestVersionData = ({ channel, currentVersion }) => {
-  const options = {
-    hostname: 'versionhistory.googleapis.com',
-    port: 443,
-    path: `/v1/chrome/platforms/linux/channels/${channel}/versions?filter=version>${currentVersion}&order_by=version%20desc`,
-    method: 'GET',
-  }
-
-  return new Promise((resolve, reject) => {
-    const req = https.request(options, (res) => {
-      let response = ''
-
-      res.on('data', (d) => {
-        response += d.toString()
-      })
+const getLatestVersionData = async ({ channel, currentVersion }) => {
+  const url = `https://versionhistory.googleapis.com/v1/chrome/platforms/linux/channels/${channel}/versions?filter=version>${currentVersion}&order_by=version%20desc`
 
-      res.on('end', () => {
-        resolve(response)
-      })
-    })
+  const response = await fetch(url)
 
-    req.on('error', (err) => {
-      reject(err)
-    })
+  if (!response.ok) {
+    throw new Error(`HTTP error! status: ${response.status}`)
+  }
 
-    req.end()
-  })
+  return await response.text()
 }
 
 const getVersions = async ({ core }) => {

scripts/unit/github-actions/update-browser-version-spec.js

@@ -1,7 +1,6 @@
 const chai = require('chai')
 const fs = require('fs')
 const mockfs = require('mock-fs')
-const nock = require('nock')
 const sinon = require('sinon')
 
 chai.use(require('sinon-chai'))
@@ -22,47 +21,51 @@ const coreStub = () => {
   }
 }
 
-const stubChromeVersionResult = (channel, result) => {
-  nock('https://versionhistory.googleapis.com')
-  .get((uri) => uri.includes(channel))
-  .reply(200, result)
-}
-
 const stubRepoVersions = ({ betaVersion, stableVersion }) => {
   mockfs({
     [CIRCLECI_WORKFLOWS_FILEPATH]: `chrome-stable-version: &chrome-stable-version "${stableVersion}"\nchrome-beta-version: &chrome-beta-version "${betaVersion}"\n`,
   })
 }
 
 const stubChromeVersions = ({ betaVersion, stableVersion }) => {
-  stubChromeVersionResult('stable',
-    {
-      versions: stableVersion ? [
-        {
-          name: `chrome/platforms/linux/channels/stable/versions/${stableVersion}`,
-          version: stableVersion,
-        },
-      ] : [],
-      nextPageToken: '',
-    })
+  if (!global.originalFetch) {
+    global.originalFetch = global.fetch
+  }
 
-  stubChromeVersionResult('beta',
-    {
-      versions: betaVersion ? [
-        {
-          name: `chrome/platforms/linux/channels/beta/versions/${betaVersion}`,
-          version: betaVersion,
-        },
-      ] : [],
-      nextPageToken: '',
-    })
+  const stableResponse = {
+    versions: stableVersion ? [{ name: `chrome/platforms/linux/channels/stable/versions/${stableVersion}`, version: stableVersion }] : [],
+    nextPageToken: '',
+  }
+
+  const betaResponse = {
+    versions: betaVersion ? [{ name: `chrome/platforms/linux/channels/beta/versions/${betaVersion}`, version: betaVersion }] : [],
+    nextPageToken: '',
+  }
+
+  global.fetch = sinon.stub().callsFake((url) => {
+    if (url.includes('/channels/stable/')) {
+      return Promise.resolve({ ok: true, status: 200, text: () => Promise.resolve(JSON.stringify(stableResponse)) })
+    }
+
+    if (url.includes('/channels/beta/')) {
+      return Promise.resolve({ ok: true, status: 200, text: () => Promise.resolve(JSON.stringify(betaResponse)) })
+    }
+
+    throw new Error(`Unexpected fetch URL: ${url}`)
+  })
 }
 
 describe('update browser version github action', () => {
   beforeEach(() => {
     sinon.restore()
     mockfs.restore()
-    nock.cleanAll()
+  })
+
+  afterEach(() => {
+    if (global.originalFetch) {
+      global.fetch = global.originalFetch
+      delete global.originalFetch
+    }
   })
 
   context('.getVersions', () => {