Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalise icon colours after Vuetify 3 upgrade #1304

Open
MetRonnie opened this issue May 22, 2023 · 5 comments
Open

Finalise icon colours after Vuetify 3 upgrade #1304

MetRonnie opened this issue May 22, 2023 · 5 comments
Assignees
Milestone

Comments

@MetRonnie
Copy link
Member

In Vuetify 2, icons had a default grey colour. In Vuetify 3 it is left up to font color inheritance, leading the icons without specified colours being (near-)black.

Some review comments on #1269 expressed a desire to retain the grey colour, however having gotten used to the darker colour I prefer it and feel it helps distinguish from disabled state. Though making them dark grey as opposed to near-black would be fine IMO

@MetRonnie MetRonnie added this to the 2.0.0 milestone May 22, 2023
@oliver-sanders oliver-sanders self-assigned this May 23, 2023
@oliver-sanders
Copy link
Member

I took a look into some of the CSS and found some issues blocking the use of the dark theme due to hardcoded values from which icon colours are derived. Should be easy to tackle both at the same time. I have a WIP branch with most hardcoded values removed and dark theme almost there.

@oliver-sanders oliver-sanders modified the milestones: 2.0.0, 2.1.0 Jul 17, 2023
@oliver-sanders oliver-sanders modified the milestones: 2.1.0, 2.2.0 Aug 15, 2023
@oliver-sanders oliver-sanders modified the milestones: 2.2.0, 2.3.0 Nov 2, 2023
@MetRonnie MetRonnie modified the milestones: 2.4.0, 2.x Mar 28, 2024
@MetRonnie
Copy link
Member Author

Can this be closed?

@oliver-sanders
Copy link
Member

Would rather niceify but don't have time right now.

@MetRonnie
Copy link
Member Author

What is trying to be addressed here? If it's dark mode we have #336. If it's finalising icons colours I don't think that's valid anymore as we have been on these icon colours for a long time.

@hjoliver
Copy link
Member

Seems eminently closable to me, but I'll leave to you guys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants