-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalise icon colours after Vuetify 3 upgrade #1304
Comments
I took a look into some of the CSS and found some issues blocking the use of the dark theme due to hardcoded values from which icon colours are derived. Should be easy to tackle both at the same time. I have a WIP branch with most hardcoded values removed and dark theme almost there. |
Can this be closed? |
Would rather niceify but don't have time right now. |
What is trying to be addressed here? If it's dark mode we have #336. If it's finalising icons colours I don't think that's valid anymore as we have been on these icon colours for a long time. |
Seems eminently closable to me, but I'll leave to you guys. |
In Vuetify 2, icons had a default grey colour. In Vuetify 3 it is left up to font color inheritance, leading the icons without specified colours being (near-)black.
Some review comments on #1269 expressed a desire to retain the grey colour, however having gotten used to the darker colour I prefer it and feel it helps distinguish from disabled state. Though making them dark grey as opposed to near-black would be fine IMO
The text was updated successfully, but these errors were encountered: