Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GScan deep watchers #1296

Open
MetRonnie opened this issue May 16, 2023 · 0 comments
Open

GScan deep watchers #1296

MetRonnie opened this issue May 16, 2023 · 0 comments
Milestone

Comments

@MetRonnie
Copy link
Member

#1269 (comment)

Problem

Deep watching workflow tree may have performance hit because we don't need to recompute the filter on every change e.g. job messages

workflows: {
deep: true,
immediate: true,
handler: 'filterWorkflows'
},

Proposed Solution

Refactor.

Solution might be to use intermediate computed properties that pull out the relevant fields and watch those instead.

@MetRonnie MetRonnie added this to the 2.x milestone May 16, 2023
@MetRonnie MetRonnie mentioned this issue May 16, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant