Log versions of Cylc, Rose and CylcRose in the rose-suite-cylc-instal… #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxtim
force-pushed
the
log_cylc_rose_version_on_install
branch
from
dc6bbcb to
e3df1d2
Compare
|
(lint failing) |
oliver-sanders
approved these changes
Nov 8, 2024
markgrahamdawson
approved these changes
Nov 28, 2024
|
Apologies it has conflicts as I took so long to review it |
wxtim
force-pushed
the
log_cylc_rose_version_on_install
branch
from
4fce292 to
b7fe636
Compare
|
@markgrahamdawson Can you just check my rebase? |
|
I wont merge this until tests are passing on master? |
wxtim
force-pushed
the
log_cylc_rose_version_on_install
branch
from
b7fe636 to
3e7278b
Compare
markgrahamdawson
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…l.conf
Closes #318
Also took the opportunity to move
tests/unit/test_functional_post_install.pytotests/functional/test_post_install.py. This has been bugging me for ages, but I dodn't want to muddy the waters of a more complex PR.Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdnot changed - this is a logging change only.Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.?.?.xbranch.