You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Because cylc install uses rsync --delete any files installed by metomi-rose file install (i.e. [file:...]) are deleted by cylc install, then re-created by cylc-rose via the post-install hook.
This is functionally ok but really inefficient. We should get fileinstall working in an incremental way (as it used to in Rose 2019).
This would involve getting cylc-rose to send back a list of the files it manages to cylc installbefore installation (i.e via a pre-install hook?) which cylc install would then add to .cylcignore (but without modifying the copy in the source dir please!).
Here's an example of how this could look:
# psudopython# ask the pre_install plugin for a list of excluded filesret=pre_install(src_dir, run_dir)
# add these to the .cylcignore in a temporary filewithTemporaryFileastemp_file:
temp_file.write(cylc_ignore.read())
temp_file.write('\n'+'\n'.join(ret['excluded_paths']))
# pass this temporary file to rsyncinstall_command= ['rsync', '--exclude-file', temp_file]
If Rose does/could support a dry-mode then this could also close #149
Pull requests welcome!
The text was updated successfully, but these errors were encountered:
Because
cylc install
usesrsync --delete
any files installed by metomi-rose file install (i.e.[file:...]
) are deleted bycylc install
, then re-created by cylc-rose via the post-install hook.This is functionally ok but really inefficient. We should get fileinstall working in an incremental way (as it used to in Rose 2019).
This would involve getting cylc-rose to send back a list of the files it manages to
cylc install
before installation (i.e via a pre-install hook?) whichcylc install
would then add to.cylcignore
(but without modifying the copy in the source dir please!).Here's an example of how this could look:
If Rose does/could support a dry-mode then this could also close #149
Pull requests welcome!
The text was updated successfully, but these errors were encountered: