Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

t5500-fetch-pack.sh test failures #45

Open
me-and opened this issue May 15, 2020 · 1 comment
Open

t5500-fetch-pack.sh test failures #45

me-and opened this issue May 15, 2020 · 1 comment

Comments

@me-and
Copy link
Member

me-and commented May 15, 2020

Bisect on the main repo points to this failure being added by ebb8d2c90f ("mingw: support UNC in git clone file://server/share/repo"). That commit changes both function and tests; running the new function with the old tests also fails, which rather implies this is a genuine regression.
@me-and
Copy link
Member Author

me-and commented Dec 11, 2022

https://github.com/git/git/blob/master/t/t5500-fetch-pack.sh#L762-L781 looks wrong to me: it's using $h with a value left over from a previous loop rather than one that's set in the containing loop. I don't think that's the cause of the failures here, but it certainly can't be helping anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@me-and