-
Notifications
You must be signed in to change notification settings - Fork 0
Add improvements to Ruby fzf, provide appropriate manpage (from older commits) #2
Comments
Seems like a good idea to me! So far I've just been naively running the install script to generate the Cygwin releases, but creating a fork of fzf that's exclusively Ruby-based seems sensible. I've created a new branch in my fork of the fzf repository, at https://github.com/me-and/fzf/tree/ruby. All I've done so far is rip out the files that are obviously Go based. In particular, I haven't looked at the current man pages, the README, etc., and I'm not quite sure when I'll have time to in the immediate future, but I'll happily accept pull requests. I think the way to go here is to start maintaining me-and/fzf and junegunn/fzf as effectively completely separate projects, one Ruby based, the other Go based. That means @junegunn no longer needs to have the Ruby code sitting around unused and untested in junegunn/fzf, and me-and/fzf can provide a fully-supported Ruby-based version of fzf for environments that don't support Go (like Cygwin) or for people who for some reason would prefer having a Ruby-based version to the Go-based one. I'll head over to @junegunn/fzf and propose that now. |
Btw, do you plan to add |
Just done. I hadn't realised they weren't enabled in the first place! |
Great. I think they are enabled by default for new repositories, but probably not when you fork a repository which already has |
Hi!
I'm using fzf on Cygwin, and recently found that some options mentioned in the manpage don't actually work, or work differently from fzf (Go) that I use on my Linux system (specifically the
-e
option).I've written a patch for the Ruby version of fzf that changes the behavior of
-e
to match the Go version, but @junegunn naturally doesn't prefer including it, it's a pain in the ass to maintain an old legacy version.So he suggests one of us maintain a ruby-only fzf repository for Cygwin (unless/until the Go version could be built on Windows).
Personally, I think it's a good idea - in the ruby repo, remove all Go-related stuff, but keep the bash scripts etc, and keep merging updates from @junegunn as possible. On the other hand, ruby script can be slightly improved if anybody wants to do that (my patch being the first change). Most importantly, the repo should use an older manpage, which is relevant to that version of fzf, not the current version's manpage, which doesn't match
fzf --help
.junegunn/fzf#547 (comment)
The text was updated successfully, but these errors were encountered: