CM-46426 - Fix severity for SCA (use Cycode severity instead of Advisory Severity) (#292)

Author: MarshalX

cycode/cli/commands/scan/code_scanner.py

@@ -695,9 +695,7 @@ def exclude_irrelevant_detections(
 def _exclude_detections_by_severity(detections: List[Detection], severity_threshold: str) -> List[Detection]:
     relevant_detections = []
     for detection in detections:
-        severity = detection.detection_details.get('advisory_severity')
-        if not severity:
-            severity = detection.severity
+        severity = detection.severity
 
         if _does_severity_match_severity_threshold(severity, severity_threshold):
             relevant_detections.append(detection)

cycode/cli/printers/tables/sca_table_printer.py

@@ -72,9 +72,8 @@ def __group_by(detections: List[Detection], details_field_name: str) -> Dict[str
 
     @staticmethod
     def __severity_sort_key(detection: Detection) -> int:
-        severity = detection.detection_details.get('advisory_severity')
-        if severity:
-            return Severity.get_member_weight(severity)
+        if detection.severity:
+            return Severity.get_member_weight(detection.severity)
 
         return SEVERITY_UNKNOWN_WEIGHT
 
@@ -138,7 +137,7 @@ def _get_table(self, policy_id: str) -> Table:
     def _enrich_table_with_values(table: Table, detection: Detection) -> None:
         detection_details = detection.detection_details
 
-        table.set(SEVERITY_COLUMN, detection_details.get('advisory_severity'))
+        table.set(SEVERITY_COLUMN, detection.severity)
         table.set(REPOSITORY_COLUMN, detection_details.get('repository_name'))
 
         table.set(CODE_PROJECT_COLUMN, detection_details.get('file_name'))