Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General discussion about the Arduino firmware #8

Open
BelaRincewind opened this issue Sep 27, 2023 · 1 comment
Open

General discussion about the Arduino firmware #8

BelaRincewind opened this issue Sep 27, 2023 · 1 comment
Assignees
Labels
help wanted Extra attention is needed

Comments

@BelaRincewind
Copy link
Contributor

Should the control for the two separate slit pairs also be cleanly separated in the code? E.g. each slit pair has its own instance of a control. Alternatively, one could just ignore the second slit pair and make it impossible (error) when trying to access it. As the used DAC has 4 channels as of now, one would have to implement such a way there anyway as both controls would share the DAC, but not its channels obviously.

@BelaRincewind BelaRincewind added the help wanted Extra attention is needed label Sep 27, 2023
@leloup314
Copy link
Member

I think that is a good idea: the most minimal yet complete control flow contains 2 slits for control of 1 respective dimension. In the code, you can have something like a PlaneController which controls exactly one plane e.g. has input of two corresponding quantities and outputs one control quantity.
Then, in the software interface, we define the how many pairs are connected to the controller: either 1 or 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants