Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registration Allows Invalid Email Addresses #552

Open
Tharsipa opened this issue Apr 7, 2024 · 1 comment
Open

Registration Allows Invalid Email Addresses #552

Tharsipa opened this issue Apr 7, 2024 · 1 comment

Comments

@Tharsipa
Copy link

Tharsipa commented Apr 7, 2024

Registration Allows Invalid Email Addresses

How to reproduce:

  1. Launch the CycleStreets app.
  2. Navigate to the dashboard
  3. Click on Settings
  4. Click on “CycleStreets account”
  5. Click on “Account Details” and then click on “Register for an account”
    • Input your name
    • An Invalid email address such as “[email protected]
    • Input your desired username
    • Input your password
  6. Submit the registration form by clicking the "Register" button.
  7. The registration process completes successfully without any error message recognizing an invalid email entered by the user.

Actual Behavior:

Expected Behaviour:

The registration process should reject the invalid email address and display an error message indicating that the email address is invalid. Users should not be allowed to register with invalid email addresses.

Device Model: Pixel 7
Android Version: Android 8.1
App version: net.cyclestreets/3.10.2/1658

Duplicate Check

I have searched the existing issues and confirm that this bug has not been reported before.

@Tharsipa Tharsipa changed the title Incorrect Retrieval of Street Names in Itinerary Registration Allows Invalid Email Addresses Apr 7, 2024
@mvl22
Copy link
Member

mvl22 commented Apr 7, 2024

The registration will not succeed because the mail then bounces, and the validation of the registration (paragraph 3) therefore cannot succeed.

Whilst a formal regexp validation could be put in, this is a losing battle and I am not of the view we should try to cope with every possible syntax.

The first sentence could be improved perhaps to avoid the implication (already clear in the third paragraph) that this completes a registration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants