Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot edit search results #874

Open
raineorshine opened this issue Sep 16, 2020 · 0 comments
Open

Cannot edit search results #874

raineorshine opened this issue Sep 16, 2020 · 0 comments
Labels
bug Something isn't working
Milestone
🔍 Search

Comments

@raineorshine
Copy link
Contributor

raineorshine commented Sep 16, 2020 •
edited
Loading

Fix and write unit test.

Steps to Reproduce

  • x
    • y
  1. Search for y using the search modal
  2. Edit y in the search results

Current Behavior

TypeError: Cannot read property 'id' of undefined

Expected Behavior

Should be able to edit y → yo yielding:

  • x
    • yo

Editing a context in a search result should modify all ThoughtContexts that it shows up in.

Note

Searching for x and editing x in the search results works fine.
@raineorshine raineorshine added the bug Something isn't working label Sep 16, 2020
@raineorshine raineorshine added the hold Pause development label Nov 15, 2020
@raineorshine raineorshine added this to the 🧠 Fluid Sensemaking milestone Jan 10, 2021
@raineorshine raineorshine removed the hold Pause development label Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
🔍 Search
Development

No branches or pull requests
1 participant
@raineorshine