Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll to visible content #446

Closed
raineorshine opened this issue Mar 23, 2020 · 2 comments
Closed

Scroll to visible content #446

raineorshine opened this issue Mar 23, 2020 · 2 comments
Labels
bug Something isn't working hold Pause development

Comments

@raineorshine
Copy link
Contributor

raineorshine commented Mar 23, 2020

In the current implementation, there’s a large amount of blank space above the thoughts when the cursor is deeply nested. Scrolling the visible content into place every time setCursor is dispatched was too disruptive. However there are some key moments where we need to scroll the visible content into place. There should be existing functionality for this already, or at least in the commit history.

  • On load from url
    • Refresh page
  • On load from saved cursor
    • Type in the home page url manually in the browser after the last cursor was deeply nested.
  • Close search
  • Internal Link
    • Context View
    • Breadcrumbs
    • Recently Edited Sidebar
@raineorshine raineorshine added bug Something isn't working dogfood labels Mar 23, 2020
@raineorshine
Copy link
Contributor Author

Consider putting the logic in the useEffect hook of the cursor thought.

@raineorshine raineorshine added the hold Pause development label Apr 28, 2020
@raineorshine
Copy link
Contributor Author

This will be a non-issue after #503.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hold Pause development
Projects
None yet
Development

No branches or pull requests

1 participant