Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync bug: contextIndex overwritten #304

Closed
5 of 7 tasks
raineorshine opened this issue Jan 25, 2020 · 1 comment
Closed
5 of 7 tasks

Sync bug: contextIndex overwritten #304

raineorshine opened this issue Jan 25, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@raineorshine
Copy link
Contributor

raineorshine commented Jan 25, 2020

Sometimes a new subthought will disappear unexpectedly.

When the subthought is added manually, all of its descendants are populated, indicating that the thoughts are being saved initially but the contextIndex entry is being overwritten.

  • How are deletions differentiated from past states?
    • Until we have write receipts or history, they aren’t. We have to use timestamps.
  • Where and how are timestamps utilized?
    • Ignored in loadLocalState
      • Should be okay since only initialState exists and the remote state is deferred.
    • updateState (requires migration to add timestamp to contextIndex)
  • Does it get overwritten by the local store or remote?
    • Must be in the remote. There is nothing for local store to overwrite.
  • Test A: Two browser tabs logged in.
    • Unable to reproduce
  • Test B: Try in various combinations.
    1. Two browser tabs logged in
    2. Go offline in tab X
    3. Make edits in tab X
    4. Reconnect in tab Y
@raineorshine raineorshine added the bug Something isn't working label Mar 23, 2020
@raineorshine raineorshine added this to the 🔄 Multi-Device Sync milestone Jan 10, 2021
@raineorshine
Copy link
Contributor Author

See if this is fixed by #230

@raineorshine raineorshine modified the milestones: *🔄 Multi-Device Sync, *⚖️ Data Integrity Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant