Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Upgrade highline gem #330

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Upgrade highline gem #330

merged 1 commit into from
Sep 29, 2021

Conversation

jtuttle
Copy link
Member

@jtuttle jtuttle commented Sep 29, 2021

Upgrades highline to fix a deprecation warning.

@jtuttle jtuttle requested a review from a team as a code owner September 29, 2021 19:06
@jtuttle
Copy link
Member Author

jtuttle commented Sep 29, 2021 •
edited
Loading

Upgrading the gem appears to make the deprecation warning go away without impairing functionality. I tested in the dev environment and confirmed that deprecation warning does appear on main but goes away when running w/ this branch. This is only testing an image built w/ Ruby 2.7 but I think that's okay given the automated testing for other Ruby versions.

imheresamir
imheresamir approved these changes Sep 29, 2021
View reviewed changes
Copy link

@imheresamir imheresamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@codeclimate
Copy link

codeclimate bot commented Sep 29, 2021

Code Climate has analyzed commit 5b29fb4 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 51.2% (0.0% change).

View more on Code Climate.

@jtuttle jtuttle merged commit 927ed81 into main Sep 29, 2021
@jtuttle jtuttle deleted the upgrade-highline branch September 29, 2021 20:01
@szamir1
Copy link

szamir1 commented Oct 31, 2021

The Ruby CLI is not planned to be released. @jtuttle are you aware of that?

@jtuttle
Copy link
Member Author

jtuttle commented Nov 1, 2021

@szamir1 Not sure what this is in reference to, the conjur-cli is one of the projects we are planning to release as part of the upcoming OSS Suite Release.

@jtuttle jtuttle mentioned this pull request Nov 12, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@imheresamir imheresamir imheresamir approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtuttle @szamir1 @imheresamir