Explicitly close connection

cwperks · cwperks · commit 4548fc912eaa · 2025-02-11T23:14:34.000-05:00
Signed-off-by: Craig Perkins &lt;cwperx@amazon.com&gt;
diff --git a/test/framework/src/main/java/org/opensearch/transport/AbstractSimpleTransportTestCase.java b/test/framework/src/main/java/org/opensearch/transport/AbstractSimpleTransportTestCase.java
@@ -3122,6 +3122,8 @@ public TransportResponse read(final StreamInput in) {
                     }
                 }
             );
+            connection.close();
+            serviceC.disconnectFromNode(nodeA);
             assertThat(te.get(), not(nullValue()));
 
             if (failToSendException instanceof IllegalStateException) {
@@ -3132,8 +3134,6 @@ public TransportResponse read(final StreamInput in) {
                 assertThat(te.get().getMessage(), equalTo("fail to send"));
                 assertThat(te.get().getCause(), nullValue());
             }
-        } finally {
-            IOUtils.close(serviceC);
         }
 
     }

Original file line number	Diff line number	Diff line change
`@@ -3122,6 +3122,8 @@ public TransportResponse read(final StreamInput in) {`
`3122`	`3122`	`}`
`3123`	`3123`	`}`
`3124`	`3124`	`);`
	`3125`	`+ connection.close();`
	`3126`	`+ serviceC.disconnectFromNode(nodeA);`
`3125`	`3127`	`assertThat(te.get(), not(nullValue()));`
`3126`	`3128`
`3127`	`3129`	`if (failToSendException instanceof IllegalStateException) {`
`@@ -3132,8 +3134,6 @@ public TransportResponse read(final StreamInput in) {`
`3132`	`3134`	`assertThat(te.get().getMessage(), equalTo("fail to send"));`
`3133`	`3135`	`assertThat(te.get().getCause(), nullValue());`
`3134`	`3136`	`}`
`3135`		`- } finally {`
`3136`		`- IOUtils.close(serviceC);`
`3137`	`3137`	`}`
`3138`	`3138`
`3139`	`3139`	`}`