Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the newest GradleKotlinConverter #4

Open
arifaizin opened this issue Jul 26, 2023 · 3 comments
Open

Update to the newest GradleKotlinConverter #4

arifaizin opened this issue Jul 26, 2023 · 3 comments

Comments

@arifaizin
Copy link

hello, I try and it has different result with the terminal version of
GradleKotlinConverter

The different is apps will result error if there is compileOptions,

Beside that, there is no parenthesis at implementation conversion.

I have tried the terminal version, and it running well. So, I thing the problem is the code is not updated. Thanks!

@cvb941
Copy link
Owner

cvb941 commented Jul 26, 2023

Hello,
This may be due to some changes I had to make in order to compile the code on the Javascript backend, as there are some regex flags that are used that are not available on Kotlin/JS.
I hoped they would add them, but so far they haven't.

@arifaizin
Copy link
Author

arifaizin commented Jul 31, 2023

Okay, thanks for the updates.
We hope they can update it, we really depend on this feature because in the new Android Studio (Giraffe) using KTS as default.

Btw, I will help to create issue to that repo, can you define the specific problem?

@cvb941
Copy link
Owner

cvb941 commented Jul 31, 2023

You can try pasting the code from the original repo into my project.

You should get errors for missing RegexOption enums, as you can see on the Kotlin Docs, they are not available for Kotlin/JS.

It would be necessary to remove those missing options and adjust each affected regex to maintain their original behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants