Removing extra commas on Manipulator class

[Draiken]

This is breaking everything using hostsfile's 2.0 version.

[Draiken]

If possible, please bump the version so I can download from opscode again :)

[sethvargo]

#29

[sethvargo]

https://github.com/customink-webops/hostsfile#requirements

[Draiken]

I'm sorry about the confusion, I wasn't trying to bring support back to 1.8, someone on our company updated the recipe without looking at the version breaking changes and when the error happened I assumed it was just the extra commas (a feature I didn't really know about 1.9).

Thanks for this great cookbook and sorry for the inconvenience.

[sethvargo]

No problem! I am just frustrated because I follow semantic versioning and clearly documented this breaking change and there were 5+ PRs fixing the issue :(

This message was sent from my mobile device.

I apologize in advance for any typographical errors or autocorrections.

On Sep 12, 2013, at 6:57 AM, "Luiz Felipe G. Pereira" [email protected] wrote:

I'm sorry about the confusion, I wasn't trying to bring support back to 1.8, someone on our company updated the recipe without looking at the version breaking changes and when the error happened I assumed it was just the extra commas (a feature I didn't really know about 1.9).

Thanks for this great cookbook and sorry for the inconvenience.

—
Reply to this email directly or view it on GitHub.

[Draiken]

I think unfortunately because of the nature of the error that shows on ruby 1.8 (invalid syntax) people think it's a simple change and end up making the pull request on a rush.

Maybe throw a specific exception when 1.8.7 is used? I guess it's not possible because the error happens when the cookbook is uploaded... I don't know how I'd deal with it.

[sethvargo]

@Draiken I'm going to release the next version with Ruby 1.9-specific hashes. There's no directive in Chef to require a specific Ruby version, unfortunately. I've added boldness to the section of the readme.