Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX New default tts missing #1767

Merged
merged 2 commits into from
Nov 2, 2022
Merged

FIX New default tts missing #1767

merged 2 commits into from
Nov 2, 2022

Conversation

provinzio
Copy link
Contributor

@provinzio provinzio commented Nov 1, 2022 •
edited
Loading

Closes #1764

alandtse
alandtse reviewed Nov 1, 2022
View reviewed changes
custom_components/alexa_media/notify.py Outdated
@@ -212,6 +212,7 @@ async def async_send_message(self, message="", **kwargs):
targets = kwargs.get(ATTR_TARGET)
title = kwargs.get(ATTR_TITLE, ATTR_TITLE_DEFAULT)
data = kwargs.get(ATTR_DATA, {})
data = data if data is None else {}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this flipped?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stupid last minute change 😴 good eye. I'll adjust it.

@provinzio provinzio requested a review from alandtse November 2, 2022 06:55
alandtse
alandtse approved these changes Nov 2, 2022
View reviewed changes
Copy link
Owner

@alandtse alandtse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@alandtse alandtse merged commit 08c2109 into alandtse:dev Nov 2, 2022
alandtse added a commit that referenced this pull request Nov 2, 2022
@alandtse
Merge pull request #1768 from custom-components/dev
06091a8 
fix(notify): handle null data key (#1767)
@pedolsky
Copy link

pedolsky commented Nov 2, 2022

Beautiful. Thank you both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alandtse alandtse alandtse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New default tts missing or misunderstanding?
4 participants
@provinzio @pedolsky @alandtse @FGH-docktor