Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DLPack a submodule? #4513

Closed
leofang opened this issue Dec 28, 2020 · 1 comment · Fixed by #4517
Closed

Make DLPack a submodule? #4513

leofang opened this issue Dec 28, 2020 · 1 comment · Fixed by #4517

Comments

@leofang
Copy link
Member

leofang commented Dec 28, 2020

I am looking into DLPack as we likely need to fix it for ROCm (it supports the kDLROCM option). One thing I noticed is that we basically reimplemented everything from the DLPack header dlpack.h in cupy/core/dlpack.pyx. I suppose like Jitify it's also a single header thing, so we might as well make it a submodule?

This will also prepare us for the Python Array API involvement, for which DLPack is being considered as the data exchange format (data-apis/consortium-feedback#1; see also the Array API Standard draft), but it currently lacks

  1. support for complex numbers (Support complex numbers in DLPack protocol dmlc/dlpack#50)
  2. specification for synchronization semantics as in CUDA Array Interface v3 (Specify synchronization semantics dmlc/dlpack#57)

so it will likely be revised in the near future. If this is acceptable then please assign it to me.

@leofang
Copy link
Member Author

leofang commented Jan 7, 2021

UPDATE: We bundle dlpack.h directly without making it a submodule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants