Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #257

Open
rdelaage opened this issue Nov 13, 2022 · 4 comments
Open

Refactoring #257

rdelaage opened this issue Nov 13, 2022 · 4 comments

Comments

@rdelaage
Copy link
Contributor

Hi, I was trying to implement #256 and was thinking that it could be a good idea to make some refactoring to the code base to maintain it more easily. Especially it could be a good idea to create some modules like config to handle all configuration thing or a logger module, add some generic functions were necessary, ...

Do you think it is a good idea ? I would be happy to work on this :)

@rdelaage
Copy link
Contributor Author

If we want to change things, I don't think the current idea of location with the "normal" and the volume type is the best. I think we can have a only type of location and volumes can be part of the from option with a special kind of prefix (e.g. volume://<name>) and optionally a path in this volume (e.g. volume://<name>/a/very/long/path)

@cupcakearmy
Copy link
Owner

Hey! Thanks for all the input! I was also in the means of refactoring, but I won't find time until january unfortunately. I see you have a lot of ideas, what about a short call the coming days?

@rdelaage
Copy link
Contributor Author

Hey! Why not, I am registered on your Discord channel if you want. I also put my thought on this document

@cupcakearmy
Copy link
Owner

Awesome! I've messaged you on discord :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants