Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show end times in widget list view #167

Open
troughc opened this issue Feb 28, 2025 · 2 comments
Open

Do not show end times in widget list view #167

troughc opened this issue Feb 28, 2025 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@troughc
Copy link

troughc commented Feb 28, 2025

1. Found this issue in the Tout Culture listing - separted it from #164

This event with a start-time and end-time (Parcours....) is now displaying a start time and end time in the list view of the widget:

Image

2. Example from Signe Laval

  • event that is showing end time in widget

This event - Louis Josee Oud (wrongly displayed as an overnight event)t**

  • also displaying a start time **and end time with the +1 for overnight
Image

Expected behaviour in LIST VIEW

Never display +1 for an overnight events; don't show end times at all
Only display date and start time for single date event with a start time and end time: do not show end times.

for reference: #54

@troughc troughc added the bug Something isn't working label Feb 28, 2025
@troughc troughc added this to the CC 2025.2 milestone Feb 28, 2025
@troughc troughc assigned sahalali and SyamBabu-M and unassigned sahalali Feb 28, 2025
@SyamBabu-M
Copy link
Contributor

SyamBabu-M commented Mar 5, 2025

@troughc @sahalali
Can you provide a list of what should be displayed for these cases?

  1. When there is only start date with a time.
  2. When the start and end are on different days, they both have a time component.
  3. When start and end are on the same day, but they both have time components.
    There are 2 cases here overnight events and single-day events.
    How will we handle overnight events? In widget V1, we were showing both the times and a "+1" symbol at the end.

@troughc
Copy link
Author

troughc commented Mar 5, 2025

@SyamBabu-M here is my guidance. cc @sahalali

  1. When there is only start date with a time.

Show the date and start time only like this (notice the vertical line between the date and time):

Image

You are already doing this (except you need to add the vertical line):

Image Image
  1. When the start and end are on different days, they both have a time component.

I am not sure I understand. Here are three cases.

  • If this is a "date range" event, the user cannot select a time (even if you have one in the back end). The date range event is a single event without a time that starts on one day and ends on another. In this case do this: First date TO second date like this
Image

I think you are already doing this

  • If this is a "multiple dates" event (an event series with sub events) and it is displayed as ONE event ("Show event occurences separately" is OFF), then show it like a date range event. Do NOT show times.
Image

I think you are already doing this

  • If this is a "multiple dates" event (an event series with sub events) and it is separated into different events ("Show event occurences separately" is ON), then show them all like single date events. Here you can show a start time if there is one. Do not show end times:

when there is no time set by the user
Image

when there is a start time
Image

when there is a start time and end time
Image

Make sure you never show end times.

  1. When start and end are on the same day, but they both have time components.

This sounds like a single date event with a start time and and end time. Do this:
Start date | Start time

Image

You already have this style - you just need to add the VERTICAL line between date and time (same as 1.)

There are 2 cases here overnight events and single-day events.
How will we handle overnight events? In widget V1, we were showing both the times and a "+1" symbol at the end.

Do this for overnight event:
Start date | Start time

Image

You already have this style - you just need to add the VERTICAL line between date and time (same as 1.)

Image Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants