Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

Revamp Weapon Wish List Data Source Solution #310

Open
cujarrett opened this issue Nov 23, 2022 · 0 comments
Open

Revamp Weapon Wish List Data Source Solution #310

cujarrett opened this issue Nov 23, 2022 · 0 comments

Comments

@cujarrett
Copy link
Owner

cujarrett commented Nov 23, 2022

What

Revamp the weapon wish list solution for Destiny insights to more closely match Twitter bot user expectations.

Context

Destiny Insights currently uses 48klocs's dim-wish-list-sources for a weapon wish list data source for weapon rolls which are determined to be tweet worthy.

Challenges

  • Weapon metas change, this can't be a one time feature, it will require seasonal updates. This mandates not only we solve the technical needs but also stand up a healthy community of maintainers to own this wish list data over time as people move on and away from the project.
  • Destiny uses itemHashes instead of words becuase of regional language differences as well as perfomance reasons. Example: 3489657138 is the itemHash for a Legendary Rocket Launcher.
  • Method to allow contributors to add rolls without a huge headache of determining itemHashes

Requirments

  • The wish list must be stored in the project via JSON, example can be seen below.
  • Create healthy docs for how current and future contributors can add, remove, or update the weapon wish list data
  • Determine contributors who will take each season for the next six months as schedule to know who to assign each seasonal refresh to.
  • Document process using GitLab issues for each change to add/ remove/ update a weapon roll from the wish list so anyone in the community can suggest a change we consider to make. Important to know the What, Why, etc. using a GitHub issue template IMO.

Format

[
...
"432476743": {
    "name": "The Palindrome",
    "type": "Legendary Hand Cannon",
    "rolls": [
      {
        "perkHashses": [
          "3250034553",
          "1561002382",
          "706527188",
          "2846385770"
        ]
      },
      {
        "perkHashses": [
          "3250034553",
          "1561002382",
          "706527188",
          "3425386926"
        ]
      },
      {
        "perkHashses": [
          "3250034553",
          "1561002382",
          "706527188",
          "2726471870"
        ]
      },
      ...
      "958384347": {
    "name": "Tomorrow's Answer",
    "type": "Legendary Rocket Launcher",
    "rolls": [
      {
        "perkHashses": [
          "3525010810",
          "3796465595",
          "951095735",
          "2396489472"
        ]
      },
      {
        "perkHashses": [
          "1478423395",
          "1996142143",
          "951095735",
          "2396489472"
        ]
      },
      ...
]

Considerations

  • I'm considering a PVE/ PVP flag for each item in the data.

Resources

Colloboration

Use comments in this issue to work out decisions, reasoning, etc.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant