-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pretty formatter #59
Conversation
Any comments on this? |
@renier sorry for the late reply, thank you for the pull request. I'll take care of this soon. |
When will this be merged? This is really missing from cucumber.js |
Some tests are missing and it needs DRYing. I'm on it. |
@jbpros If you think there is anything I can do to help, let me know. |
@renier Thanks. I'm reviewing your pull request to see how it fits with the latest refactorings. I'll try merging it but we probably need a few scenarios to test the pretty formatter. |
As you can see in the spike, it's much easier to add a formatter. This pull request is quite different and we should probably start over by importing the bits still relevant to the current codebase. |
@jbpros it looks like you have it already. the only thing I'm not seeing is being able to select one formatter over the other from the command line. Do you want me to do that? I have tests in the pull request. A lot of them don't apply now that you have separated things, but the ones pertinent to the pretty formatter are among them. |
Yep, the listener instantiation is hardcoded. This is just a spike (non-tested, cow-boy-style code) to prove everything is ready for the pretty formatter. I'd like it to be rewritten following the normal BDD approach, with gherkin scenarios and jasmine specs. Of course, all the code you wrote previously that is still relevant can be reused. I might get some time tonight to work on it but if you want to take back the control of this pull request, you're welcome! I'd like to close it as soon as possible though, it's been requested by many people, for quite a long time. |
@joshski Thanks! I really need pretty formatter! |
@LabiKyo np -- it's available on 0.2.17 Please note it needs improvement. There are no colours, and some things are not output yet (tags, comments, etc.). |
@jbpros Yes I've tried. I'd like to contribute this part, too. I'm trying some modules to print colorful output. |
@LabiKyo neat -- feel free to submit things! |
Creating new pull request for adding the colors. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Adds a pretty printer listener/formatter, updates the help text, and adds specs for the new formatter.