Feature/strictmode #258
Closed
Feature/strictmode #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added three scenarios that describe what strict mode should behave like. These were taking from the cucumber ruby feature, and then reworked quite a bit. Also, the original cucumber scenario doesn’t include the case for pending steps, I have now added that one as well. ( see https://github.com/cucumber/cucumber/blob/master/features/docs/cli/strict_mode.feature ) The steps were refactored to be based on aruba steps, since the cli.feature depends on aruba.
The strict was missing compared to the cucumber ruby and jvm implementations. The strict mode flag was added to the configuration classes. The ast_tree_walker interprets the strict mode and if set, sets allFeaturesSucceded to false when witnessing a pending or undefined step. The runtime spec was adjusted to run all test for both strict and non- strict. The VolatileConfiguration also was updated. Strict mode is enable if options has a strict field with true.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add strict mode ( #58 )
Only saw strict mode pr #211 when creating this pull request.
Looks similar to #211 but this also includes strict mode for the volatile configuration.
Not sure if you want this pr.