-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: scoped package name #1411
Conversation
You'll need to update this https://github.com/cucumber/cucumber-js/blob/master/features/support/hooks.ts#L39 where we symlink cucumber as a node module in the tmp dir that each feature runs in. Similarly will probably need to update this: https://github.com/cucumber/cucumber-js/blob/master/features/support/hooks.ts#L64 |
Nevermind, now see that you did that already |
Found the issue. And updated the thrown error so it would be easier to understand in the future. |
Thanks - interesting that dependency-lint has flagged our own package name as being a missing dev dependency - on all versions of Node, but not on Windows, and not on my Mac either. I'll keep digging... |
Hmm so that appears to be reporting that a binary exposed by it is used in a few places. Not sure why its listed as a devDependency either |
Re the old package, the done thing seems to be to use |
Co-authored-by: Charles Rudolph <[email protected]>
Co-authored-by: Charles Rudolph <[email protected]>
This would I guess be the last thing to do before publishing a stable 7.0.0.
Would we want to also publish an update to the current package name as a 6.x.x patch with a message to migrate?
(Also, can't quite figure out what I've missed to get the features working with require-ing the new name.)