vary error for callback vs promise

[bruce-lindsay]

#1019

[charlierudolph]

Thanks for the PR!

[charlierudolph]

Can we do what was done earlier in this file?

[charlierudolph]

Can we update this to: function timed out, ensure the callback is executed within 500 milliseconds?

[bruce-lindsay]

@charlierudolph sure thing. Glad to be able to help. I addressed your feedback in the latest commit. I thought I was being smart by reducing some of the repetitiveness but this is more consistent. Let me know if I missed anything else.

[aslakhellesoy]

Hi @bruce-lindsay,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
• 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.