Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs/nodejs_example.md #898

Merged
merged 1 commit into from
Aug 11, 2017
Merged

Update docs/nodejs_example.md #898

merged 1 commit into from
Aug 11, 2017

Conversation

JoaoGFarias
Copy link

@JoaoGFarias JoaoGFarias commented Aug 11, 2017

The cucumber-expression 'stringInDoubleQuotes' has become simply 'string' Reference

Updating NodeJS example to reflect this change.

The cucumber-expression 'stringInDoubleQuotes' has become simply 'string' [Reference](https://github.com/cucumber/cucumber-js/blob/master/CHANGELOG.md#breaking-changes)

Updating nodejs_example to reflect this change
@charlierudolph charlierudolph merged commit 7d31882 into cucumber:master Aug 11, 2017
@aslakhellesoy
Copy link
Contributor

Hi @JoaoGFarias,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for we ask you to:

  • ✅ Please continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@charlierudolph
Copy link
Member

Thanks!

@lock
Copy link

lock bot commented Oct 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants