Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cross-platform symbols #635

Merged
merged 2 commits into from
Sep 12, 2016
Merged

Use cross-platform symbols #635

merged 2 commits into from
Sep 12, 2016

Conversation

kevgo
Copy link
Contributor

@kevgo kevgo commented Sep 11, 2016

@charlierudolph

Some Windows shells only support a limited character set. Using figures makes the new unicode output of Cucumber more compatible across all platforms.

characters[Cucumber.Status.AMBIGUOUS] = '✖';
characters[Cucumber.Status.FAILED] = '✖';
characters[Cucumber.Status.PASSED] = '✓';
characters[Cucumber.Status.AMBIGUOUS] = figures.warning;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep this as figures.cross. Failed and ambiguous are both treated as "Failures" in the summary output so I'd like them to use the same symbol

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@charlierudolph
Copy link
Member

Very cool. Thanks for this @kevgo. I want to setup appveyor anyway so we can make sure things are working for windows.

@kevgo
Copy link
Contributor Author

kevgo commented Sep 11, 2016

All comments addressed

@kevgo
Copy link
Contributor Author

kevgo commented Sep 11, 2016

Btw please check out https://github.com/Originate/exo-add for a working example of a Node code base on AppVeyor. In particular:

@charlierudolph charlierudolph merged commit 95544b6 into cucumber:master Sep 12, 2016
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants