Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoffeeScript support #29

Closed
wants to merge 3 commits into from
Closed

CoffeeScript support #29

wants to merge 3 commits into from

Conversation

paulbjensen
Copy link
Contributor

Hi

I've added CoffeeScript Support for Cucumber.js.

Regards,

@paulbjensen
Copy link
Contributor Author

I will write the specs tomorrow morning (apologies for not doing pure TDD, I will look to improve on that).

@paulbjensen
Copy link
Contributor Author

Hi,

I had a go at trying to write some specs for this, but failed miserably. I initially thought about setting up a spy on the require function to intercept it being called with a CoffeeScript file in the path. Does that sound like a good test?

@jbpros
Copy link
Member

jbpros commented Oct 11, 2011

Yeah spying on require should be fine. I've added a helper for this: https://github.com/cucumber/cucumber-js/blob/master/spec/cucumber/cli/argument_parser_spec.js#L11

I was wondering: couldn't we simply require the coffeescript module once as a hard dependency and not care about it when loading support code? Would that be a performance bugger?

@paulbjensen
Copy link
Contributor Author

We can, in fact that simplifies the code, and kind of makes sense since CoffeeScript will be a package dependency anyway.

Thanks for the pointer on the spy helper. I'll do some coding on it now.

* Tested the Regex that matches step definition files based on their file extension.
@jbpros jbpros closed this in 6ae8b2d Oct 12, 2011
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants