Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support code loader now works with windows #226

Closed
wants to merge 1 commit into from

Conversation

garytaylor
Copy link
Contributor

Hi,
I found an issue when running cucumberjs under windows. It was not loading the support files before the step definitions. This was because the regexp in the support_code_loader.js file was hard coded to a 'normal' file path. Obviously, windows has to be different as always, so I have added a test for the windows platform and used backslashes in the regexp when this test passes.
I have since ran the unit tests which all pass

I could not think of a way to test this change in the unit test as I needed to spy on 'os.platform()' and return different values. This would have needed to have been done before the code was loaded.

I have also tested it using my test suite (which contains a good 200+ steps) and it works on both linux (which it always did) and windows (which didn't work previously).

This pull request as you can see contains the required change.

Hopefully you can include this in the next release and I can remove my fork from github.

Thanks

Gary

@jbpros jbpros closed this in 8542aa1 Dec 18, 2014
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants