--no-snippets flag for CLI #207
Conversation
|
+1 |
|
As I can see this is already implemented in the CLI of |
|
Four days left and no comment from the maintainers? |
|
Ooh, this is nice. |
| @@ -52,6 +54,11 @@ describe("Cucumber.Cli.Configuration", function () { | |||
| expect(argumentParser.shouldSnippetsBeInCoffeeScript).toHaveBeenCalled(); | |||
| }); | |||
|
|
|||
| it("checks whether the step definition snippets should be shown", function () { | |||
| configuration.getFormatter(); | |||
| expect(argumentParser.shouldSnippetsBeShown).toHaveBeenCalled(); | |||
There was a problem hiding this comment.
Can you put a call count assertion on this please :)
|
Hi @kr1sp1n this looks great! just a few minor comments, thanks for the work. |
|
@kr1sp1n would you mind squashing your three commits into a singe one. |
add specs and implement tests add callCount assertion to tests
…umber-js into cli-no-snippets-flag
|
Thanks @kr1sp1n for this nice piece. Cucumber-rb's got a shorthand version of |
|
Anything left? Is all ok now? |
|
hey @kr1sp1n yes this is all good now we just missed it when we cut the last release. This will go out soon. |
|
👍 |
|
Thanks @kr1sp1n, this is good work! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Now you are able to pass
--no-snippetsto the CLI and the formatters will not output the step definition snippets. So I added asnippetskey to theoptionsof the CLI configuration and set the value totrueby default. Thisoptionsobject gets passed down to the summary formatter that supress the output of the snippets. I refactored the existing tests and added new specs and tests.Hope this is helpful ;)