Documentation and test for AfterFeatures event #171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… causes the exit code to always equal 0 Signed-off-by: Eddie Loeffen <[email protected]>
…terHandler" function. This makes the test pass correctly. Signed-off-by: Eddie Loeffen <[email protected]>
Update documentation to include the AfterFeatures event, and add a mention to the other events available through the registerHandler function.
…uild to fail. Signed-off-by: Eddie Loeffen <[email protected]>
…ailing tests. Signed-off-by: Eddie Loeffen <[email protected]>
…d correctly strip color codes and normalize new line characters before checking the two strings Signed-off-by: Eddie Loeffen <[email protected]>
…t contains a lot more stuff in between "F" and "1 scenario..." Signed-off-by: Eddie Loeffen <[email protected]>
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spent ages doing the wrong setup for AfterFeatures to try and close my browser at the end of the tests, so I thought that including a test and better documentation might help other people.
This also fixes the unimplemented cli.feature step, and failing assert due to console coloring.
I had to apply the patch from comments in #120 to get these tests to run correctly.