Scenario outlines redux

[vantreeseba]

A different implementation of #75, this addresses #10 as well.

Currently, this spec does NOT rename the scenarios generated from the outline scenario.

Everything should be covered by spec tests.

Please suggest any changes to implementation, hopefully we can all get this feature completed and integrated :)

[vantreeseba]

@jbpros I noticed in the other pull request you mentioned that this needs to be tested thoroughly in the cucumber-tck.

From what I can tell, the cucumber-tck is a "base line for all implementations of cucumber", but currently cucumber-js has no defined steps for any of the cucumber-tck features, and the feature file for the scenario_outlines is empty.

How should I remedy this situation?

[buritica]

Hey all, by running cucumber.js with no arguments on this branch I'm getting the following:

/Users/buritica/htdocs/cucumber-js/lib/cucumber/ast/assembler.js:88
      currentScenarioOrBackground.setExamples(examples);
                                  ^
TypeError: Object #<Object> has no method 'setExamples'

You can see the rest of the trace, including the feature file and the log of currentScenarioOrBackground object at https://gist.github.com/Buritica/9040233

I cloned @vantreeseba's fork and npm linked it to both my global and local installations of cucumber. Is there anything I am missing or do you need other information from the error?.

[vantreeseba]

@buritica I'm looking into this now.

[vantreeseba]

@buritica You must name the scenario a scenario outline instead. From what I can tell this is the way that regular cucumber works as well.

I will add a check in the assembler that gives you a better warning instead of an explosion. :)

[vantreeseba]

@buritica As of the newest commit, this should give you a proper error message.

[buritica]

Thanks @vantreeseba, should have read better. I'm just getting started with Cucumber in general, so thank you for pointing this out.

After changing this to a Scenario Outline things work as expected, although the Scenario is run twice. Not sure if expected:

[vantreeseba]

@buritica Can you repaste your new feature file for me so I can try and replicate this issue again?

I used the original one in your gist, and cannot replicate.

[buritica]

You can get it from here, https://cloudup.com/cy8L2sCgu48. I also added a screenshot, it seems to run steps twice for every example. Let me know if I can help you more.

[vantreeseba]

Yeah, I have this duplicated now, I"m looking into it. Thanks for the bug report :)

[vantreeseba]

@buritica I found the duplicated steps issue and have corrected it.

[AdrienLemaire]

Wonderful, seems like I'll be able to use cucumber-js in my project real soon :D Thank you very much for your hard work @vantreeseba !

[alexoldenburg]

I could really use this great feature!
Could you give us an update on how long we have to wait for this feature to be merged?

Thanks in advance,

Ilinea

[jbpros]

Thank you @fedotov-danil and @vantreeseba for your hard work. This is awesome!

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.