From b1252df57768bab6eac7eb4ea348bb02139024ff Mon Sep 17 00:00:00 2001 From: Matijs van Zuijlen Date: Fri, 21 Aug 2020 15:47:47 +0200 Subject: [PATCH 1/3] Allow Cucumber 5.0 --- aruba.gemspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/aruba.gemspec b/aruba.gemspec index 3553b5d63..3098ba6b3 100644 --- a/aruba.gemspec +++ b/aruba.gemspec @@ -23,7 +23,7 @@ Gem::Specification.new do |spec| spec.add_runtime_dependency 'childprocess', ['>= 2.0', '< 5.0'] spec.add_runtime_dependency 'contracts', '~> 0.16.0' - spec.add_runtime_dependency 'cucumber', ['>= 2.4', '< 5.0'] + spec.add_runtime_dependency 'cucumber', ['>= 2.4', '< 6.0'] spec.add_runtime_dependency 'ffi', '~> 1.9' spec.add_runtime_dependency 'rspec-expectations', '~> 3.4' spec.add_runtime_dependency 'thor', '~> 1.0' From 77a16e6925a7be95ae43321264a9dce0ab029409 Mon Sep 17 00:00:00 2001 From: Matijs van Zuijlen Date: Fri, 21 Aug 2020 15:48:53 +0200 Subject: [PATCH 2/3] Loosen dependency on simplecov --- aruba.gemspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/aruba.gemspec b/aruba.gemspec index 3098ba6b3..e0b00974e 100644 --- a/aruba.gemspec +++ b/aruba.gemspec @@ -39,7 +39,7 @@ Gem::Specification.new do |spec| spec.add_development_dependency 'rubocop-packaging', '~> 0.3.0' spec.add_development_dependency 'rubocop-performance', '~> 1.7.1' spec.add_development_dependency 'rubocop-rspec', '~> 1.43.1' - spec.add_development_dependency 'simplecov', '~> 0.18.0' + spec.add_development_dependency 'simplecov', ['>= 0.18.0', '< 0.20.0'] spec.add_development_dependency 'yard-junk', '~> 0.0.7' spec.rubygems_version = '>= 1.6.1' From 93de81eea9d97163a424fc8c2142d8b591bc8f9a Mon Sep 17 00:00:00 2001 From: Matijs van Zuijlen Date: Fri, 21 Aug 2020 18:00:28 +0200 Subject: [PATCH 3/3] Loosen expectation of output This keeps the 'Diff:' part to indicate that some kind of diff should be output, but doesn't dictate the format of the diff, since that detail is not really important for this scenario. --- .../cucumber/steps/command/check_output_of_command.feature | 5 ----- 1 file changed, 5 deletions(-) diff --git a/features/03_testing_frameworks/cucumber/steps/command/check_output_of_command.feature b/features/03_testing_frameworks/cucumber/steps/command/check_output_of_command.feature index a1acf544d..8061f9c81 100644 --- a/features/03_testing_frameworks/cucumber/steps/command/check_output_of_command.feature +++ b/features/03_testing_frameworks/cucumber/steps/command/check_output_of_command.feature @@ -201,11 +201,6 @@ Feature: All output of commands which were executed """ expected "goodbye\nworld" to output string is eq: "hello\nworld" Diff: - @@ -1,3 +1,3 @@ - -hello - +goodbye - world - (RSpec::Expectations::ExpectationNotMetError) """ Scenario: Detect subset of one-line output with regex