Skip to content

Commit 75fc309

Browse files
caitlynjinrs929vinnie4k
authored
Release 3.0.0 Build 33 (#71)
* Addressed Matt's comments - Removed TabView and used environment object to allow tab bar to be hidden when necessary - Allowed rescaling of font size for class title - Added instructor label * Merge Release to Main (#69) * Add support for custom GraphQL errors * Remove codegen build phase * Implemented classes page - Performed soft reset and squashing the previous commits - Implemented ClassesView, ClassCell, ClassDetailView, NextSessionCell, and ClassesViewModel - Created FitnessClass and FitnessClassInstance models - Other modifications to create the classes screens * Comment out giveaway modal on home * Update Package.resolved * Updated build number * Release 2.5.8 Build 29 (#68) * Add support for custom GraphQL errors * Update queries * Remove codegen build phase * Implemented classes page - Performed soft reset and squashing the previous commits - Implemented ClassesView, ClassCell, ClassDetailView, NextSessionCell, and ClassesViewModel - Created FitnessClass and FitnessClassInstance models - Other modifications to create the classes screens * Comment out giveaway modal on home * Optimized filtered classes * Optimized next sessions * Cleaned up code * Update fragments and mutations * Fixed error due to updated mutation * Update project.pbxproj * Create Package.resolved --------- Co-authored-by: Vin Bui <[email protected]> Co-authored-by: Vin Bui <[email protected]> --------- Co-authored-by: Vin Bui <[email protected]> Co-authored-by: Caitlyn Jin <[email protected]> Co-authored-by: Caitlyn Jin <[email protected]> Co-authored-by: Vin Bui <[email protected]> * Update build and version number --------- Co-authored-by: Richie Sun <[email protected]> Co-authored-by: Vin Bui <[email protected]> Co-authored-by: Vin Bui <[email protected]>
1 parent 96c1b05 commit 75fc309

File tree

4 files changed

+20
-10
lines changed

4 files changed

+20
-10
lines changed

Uplift.xcodeproj/project.pbxproj

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -902,7 +902,7 @@
902902
ASSETCATALOG_COMPILER_INCLUDE_ALL_APPICON_ASSETS = NO;
903903
CODE_SIGN_IDENTITY = "Apple Development";
904904
CODE_SIGN_STYLE = Automatic;
905-
CURRENT_PROJECT_VERSION = 28;
905+
CURRENT_PROJECT_VERSION = 33;
906906
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
907907
DEVELOPMENT_TEAM = ZGMCXU7X3U;
908908
ENABLE_PREVIEWS = YES;
@@ -923,7 +923,7 @@
923923
"$(inherited)",
924924
"@executable_path/Frameworks",
925925
);
926-
MARKETING_VERSION = 2.5.7;
926+
MARKETING_VERSION = 3.0.0;
927927
OTHER_LDFLAGS = "-ObjC";
928928
PRODUCT_BUNDLE_IDENTIFIER = com.cornellappdev.uplift.ios;
929929
PRODUCT_NAME = "$(TARGET_NAME)";
@@ -946,7 +946,7 @@
946946
ASSETCATALOG_COMPILER_INCLUDE_ALL_APPICON_ASSETS = NO;
947947
CODE_SIGN_IDENTITY = "Apple Development";
948948
CODE_SIGN_STYLE = Automatic;
949-
CURRENT_PROJECT_VERSION = 28;
949+
CURRENT_PROJECT_VERSION = 33;
950950
DEVELOPMENT_TEAM = ZGMCXU7X3U;
951951
ENABLE_PREVIEWS = YES;
952952
GENERATE_INFOPLIST_FILE = YES;
@@ -966,7 +966,7 @@
966966
"$(inherited)",
967967
"@executable_path/Frameworks",
968968
);
969-
MARKETING_VERSION = 2.5.7;
969+
MARKETING_VERSION = 3.0.0;
970970
OTHER_LDFLAGS = "-ObjC";
971971
PRODUCT_BUNDLE_IDENTIFIER = com.cornellappdev.uplift.ios;
972972
PRODUCT_NAME = "$(TARGET_NAME)";

Uplift/Views/Classes/ClassDetailView.swift

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,13 +99,15 @@ struct ClassDetailView: View {
9999
.font(Constants.Fonts.s1)
100100
.foregroundStyle(Constants.Colors.white)
101101
.multilineTextAlignment(.center)
102+
.minimumScaleFactor(0.01)
103+
.lineLimit(2)
102104

103105
Text(classInstance.location)
104106
.font(Constants.Fonts.bodyNormal)
105107
.foregroundStyle(Constants.Colors.white)
106108
.multilineTextAlignment(.center)
107109

108-
Text(classInstance.instructor.uppercased())
110+
Text("INSTRUCTOR: \(classInstance.instructor.uppercased())")
109111
.font(Constants.Fonts.h2)
110112
.foregroundStyle(Constants.Colors.white)
111113
.multilineTextAlignment(.center)

Uplift/Views/ClassesView.swift

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ struct ClassesView: View {
1313

1414
// MARK: - Properties
1515

16+
@EnvironmentObject var tabBarProp: TabBarProperty
1617
@StateObject private var viewModel = ViewModel()
1718
@State private var weeks: [Int] = [0, 1, 2] // Integers represent the number of weeks from the current week
1819

@@ -184,6 +185,8 @@ struct ClassesView: View {
184185
ForEach(viewModel.filteredClasses, id: \.self) { classInstance in
185186
NavigationLink {
186187
ClassDetailView(classInstance: classInstance, viewModel: viewModel)
188+
.onAppear { tabBarProp.hidden = true }
189+
.onDisappear { tabBarProp.hidden = false }
187190
} label: {
188191
ClassCell(classInstance: classInstance, viewModel: viewModel)
189192
}

Uplift/Views/MainView.swift

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ struct MainView: View {
1414
// MARK: - Properties
1515

1616
@State private var selectedTab: Screen = .home
17+
@StateObject var tabBarProp = TabBarProperty()
1718
@StateObject private var viewModel = ViewModel()
1819

1920
// MARK: - UI
@@ -23,15 +24,15 @@ struct MainView: View {
2324
HomeView(popUpGiveaway: $viewModel.popUpGiveaway)
2425

2526
ZStack(alignment: .bottom) {
26-
TabView(selection: $selectedTab) {
27+
switch selectedTab {
28+
case .home:
2729
HomeView(popUpGiveaway: $viewModel.popUpGiveaway)
28-
.tag(Screen.home)
29-
30+
case .classes:
3031
ClassesView()
31-
.tag(Screen.classes)
32+
.environmentObject(tabBarProp)
3233
}
3334

34-
tabBar
35+
!tabBarProp.hidden ? tabBar : nil
3536
}
3637

3738
if viewModel.popUpGiveaway {
@@ -131,6 +132,10 @@ extension MainView {
131132

132133
}
133134

135+
final class TabBarProperty: ObservableObject {
136+
@Published var hidden: Bool = false
137+
}
138+
134139
#Preview {
135140
MainView()
136141
}

0 commit comments

Comments
 (0)