Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addLocalFolderPromise is broken when providing absolute path on mac #532

Open
koush opened this issue Aug 13, 2024 · 1 comment
Open

addLocalFolderPromise is broken when providing absolute path on mac #532

koush opened this issue Aug 13, 2024 · 1 comment

Comments

@koush
Copy link

koush commented Aug 13, 2024

caused by this change. fixPath is calling path.join which will join two absolute paths.

https://github.com/cthackers/adm-zip/blame/b148463f5f9f67427df6dd19798cdce20bde3d74/adm-zip.js#L488

@wimbarelds
Copy link

Also have this issue. Resulting zip is empty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants