Broken chrome builtin unpackaging compatibility

[skoniks]

I don't consider myself an expert on working with zip archives, but i detected that commit 9c37fa8 brokes compatibility with chrome extension unpackaging compatibility on windows (may be not only on windows).

Attempting to install archived extension you receive an error and temporary extracting folder looks like this:

[skoniks]

Utils.canonical replaces backslash to slash, that somehow broken archive extraction

[5saviahv]

Interesting, APPNOTE says you should use slash, but backslashes are also permitted in zip files.

idea for adding function there is avoid constructing file names like ..\..\..\windows\system32\drivers\etc\hosts
I have some zip archives created in windows with tools like 7z, WinZIP and they all use slashes.

but I think if chrome really uses backslashes we should add option like useBackslash.

[skoniks]

Interesting, APPNOTE says you should use slash, but backslashes are also permitted in zip files.

idea for adding function there is avoid constructing file names like ..\..\..\windows\system32\drivers\etc\hosts I have some zip archives created in windows with tools like 7z, WinZIP and they all use slashes.

but I think if chrome really uses backslashes we should add option like useBackslash.

As i mentioned before, problem is specific for creating archive on windows, broken archives cause error in all desktop browsers (Opera, Edge, Firefox and others, not only Chrome) for windows and mac. I tried creating the same archive with same pkg version from mac and it do not cause any errors. So i conclude that the problem is specific only for windows, not for browsers.

In other words browsers are incompatible with windows created archives, after changing to backslash 🤔

[skoniks]

Utils.canonical replaces backslash to slash, that somehow broken archive extraction

After some research promlem was opposite in replacing shashes on backslashes, Utils.canonical uses POSIX pth.posix.normalize, and then uses non POSIX pth.join that leads to an error