Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fullscreen-playback-of-switching-sets__ss1-1.html failed in all TV sets in London plugfest #150

Open
jpiesing opened this issue Mar 15, 2024 · 9 comments
Assignees
Labels
London 2024 Plugfest Issues from London plugfest in Feb/Mar 2024 Release V2 Deferred to Release V2

Comments

@jpiesing
Copy link

jpiesing commented Mar 15, 2024

In both fullscreen-playback-of-switching-sets__ss1-1.html and ss1-2, the observation "[OF] Video: The presented sample shall match the one reported by the currentTime value within the tolerance of +/-(2/framerate + 20ms)" failed on all 8 TV sets in the London plugfest.

@jpiesing jpiesing added Release V2 Deferred to Release V2 London 2024 Plugfest Issues from London plugfest in Feb/Mar 2024 labels Mar 15, 2024
@yanj-github
Copy link
Contributor

Hi @jpiesing,
After change the tolerance to 1frame + 150ms now just failing on one occasion. It is the point when switching happens. We did double check the OF to make sure it uses right frame rate.
Allowed tolerance is 1 frames, 150ms. Time difference between Test Runner reported media currentTime and actual media time exceeded tolerance for following events: currentTime=46.11 time_diff=210.0; Total failure count is 1.

@FritzHeiden can you kindly help to double check the currentTime report at the switching point to make sure it reported correctly please?

@FritzHeiden
Copy link
Collaborator

@yanj-github Updating the qr code is coupled to several events. Some of them include: video enters waiting state, currently playing representation changes, video buffers, video starts playing, timeupdate event

Anytime the qr code is updated it uses the currentTime value reported by the API

@jpiesing
Copy link
Author

@yanj-github Updating the qr code is coupled to several events. Some of them include: video enters waiting state, currently playing representation changes, video buffers, video starts playing, timeupdate event

Anytime the qr code is updated it uses the currentTime value reported by the API

@FritzHeiden @yanj-github Would it help if the two of you discussed this in a zoom/teams call? Otherwise I'm not sure this is going anywhere.

@yanj-github
Copy link
Contributor

@jpiesing and @FritzHeiden I have created a new issue for this #172

@jpiesing
Copy link
Author

@yanj-github Now #172 is closed, is there anything left in this issue?

@yanj-github
Copy link
Contributor

@jpiesing It can be closed if you are happy. The latest result I sent you these are all PASS now.

@jpiesing
Copy link
Author

@jpiesing It can be closed if you are happy. The latest result I sent you these are all PASS now.

That's not correct - at least how I interpret the words. Of course you may have meant something different.

I can see failures due to last frame not being shown - which may be another example of #156.

ss1-2 fails with a duration error.

@yanj-github
Copy link
Contributor

yanj-github commented May 14, 2024

@jpiesing I thought this issue only meant current time match test. If you meant test with other observations then yes some observations failed.

Regarding to duration check it might be related to cta-wave/device-observation-framework#59 (comment). A1 (low resolution) presented at the beginning this is harder to detect when fading in it might impact how accurate we can calculate duration.
Here are the options:

  • Better recording such as recording taken in controlled environment (as we suggested in OF documentation) will make is pass. Recommended.
  • Use more recent version of OpenCV. Not recommended at this stage we are close to release.
  • Update playout parameter to have higher resolution content to begin with. This is the best option as we dont want to make is so hard to PASS duration check. Feedback and help required on this, I am not sure the impact and how easy to test this. NOTE: A1 is on 12.5 fps frame duration is 80ms but duration tolerance is 50ms. With ideal recording the detected duration will be accurate but on the worst case detected duration may be short for up to 80ms.

@jpiesing
Copy link
Author

2024-05-28: This remains open until it's been run with the new debugging support so we can see what happens with the last frame. It needs to be re-run on the exact same model of TV as exhibited the original problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
London 2024 Plugfest Issues from London plugfest in Feb/Mar 2024 Release V2 Deferred to Release V2
Projects
None yet
Development

No branches or pull requests

3 participants