Point switcher JSON to its version on latest readthedocs build #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HealthyPear
added
documentation
Codecov Report
@@ Coverage Diff @@
## master #199 +/- ##
=======================================
Coverage 63.11% 63.11%
=======================================
Files 28 28
Lines 2890 2890
=======================================
Hits 1824 1824
Misses 1066 1066 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully, this closes #195.
The reason behind the malfunction might be a CORS (Cross-Origin Resource Sharing) issue: basically an issue in sharing URLs access between different APIs (in our case GitHub and readthedocs).
During the build on readthedocs (in our case) it should be more safe to stay "there" when looking for reference files at specific URLs.
The documentation build from the CI should work anyways as it doesn't use the latest JSON file (the PR has a more predictable reference).