Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Notebooks should try to import uproot only if ROOT-based data is required #173

Open
HealthyPear opened this issue Mar 2, 2022 · 0 comments
Labels
benchmarks bug Something isn't working
Milestone

Comments

@HealthyPear
Copy link
Member

Describe the problem

In some notebooks, the uproot library is always imported.
If the user doesn't need /want to bother with ROOT-based data for comparisons, there will be no uproot in the virtual environment.

To Reproduce
Steps to reproduce the behavior:

  1. Launch the DirectionLUT benchmark with no uproot and no CTAMARS or EventDisplay data.

Expected behavior

After parameter injection, only if any boolean variable is used to load 3rd party ROOT-based data there should be the import.
If uproot is not present and e.g. load_CTAMARS is False, the notebook shouldn't crash with an ImportError.

@HealthyPear HealthyPear added bug Something isn't working benchmarks labels Mar 2, 2022
@HealthyPear HealthyPear added this to the v0.5.0 milestone Mar 2, 2022
@HealthyPear HealthyPear modified the milestones: v0.5.0, v0.5.1 Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarks bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant