Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set use_ssl to True as default #303

Closed
edenhaus opened this issue Apr 19, 2020 · 2 comments
Closed

Set use_ssl to True as default #303

edenhaus opened this issue Apr 19, 2020 · 2 comments
Assignees
Milestone

Comments

@edenhaus
Copy link
Contributor

Ciao Claudio,

Nowadays the most traffic already is using https and I think we should activate it as default.
We are always sending our api key in our requests. What do you think?

Saluti dall'alto adige

@csparpa
Copy link
Owner

csparpa commented Apr 20, 2020

Ciao,

it seems very reasonable to me :)

Would you please modify that flag in the default configuration and run all tests (unit + integration) just to make sure everything works?
In particular, I'd check that the HTTP client library (requests) works as expected

Thank you very much!

PS: I'm literally craving for a trekking session in Alto Adige - it's been 3 years since the last one!!

@csparpa
Copy link
Owner

csparpa commented Apr 21, 2020

Fixed by #305

@csparpa csparpa closed this as completed Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants