Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BMI-Tester problems for C / C++ examples #107

Open
Volk3rJ opened this issue Apr 26, 2024 · 7 comments
Open

BMI-Tester problems for C / C++ examples #107

Volk3rJ opened this issue Apr 26, 2024 · 7 comments

Comments

@Volk3rJ
Copy link

Volk3rJ commented Apr 26, 2024

When going though the HeatModel C and C++ examples, I ran into a problem with the bmi-tester. Everything up to this point works fine (under Linux). However, running the bmi-test command leads to the following output... (attached).

bmi-test_errors.txt

Since I can import both the babelized pymt_heatc / pymt_heatcxx models without any problem, I assume the errors are with the BMI-Tester (version 0.5.9)?

@mdpiper
Copy link
Member

mdpiper commented Apr 26, 2024

This is the "pytest fixtures not found" issue that has recently cropped up. I think it can be avoided by installing all dependencies when creating an environment.

@Volk3rJ
Copy link
Author

Volk3rJ commented May 10, 2024

@mdpiper - Thank you for the reply. Not sure what might be missing in my environment. Which dependencies are you specifically referring to? I attached the list of packages below if that helps narrow it down.

wrap-all_package_list.txt

@aufdenkampe
Copy link

@mdpiper, the conda environment used by @Volk3rJ was built from the same babelizer-examples/environment.yml that I previously used to build an environment from your mdpiper/add-cxx-example branch that worked with your new C++ example for me on MacOS.

@mcflugen
Copy link
Member

@aufdenkampe, @Volk3rJ Sorry for the delay, I somehow missed this. I don't think the issue has anything to do with your dependencies. For some reason the bmi-tester is having trouble finding its initialized_bmi fixture, which is defined in bmi_tester/_tests/conftest.py. I'm not sure why this is but I'll see if I can reproduce it.

Could you please give me the versions you are using for,

  • Python (looks like 3.12.3?)
  • pytest (looks like 8.1.1?)
  • bmi-tester

And what OS are you both using?

@Volk3rJ
Copy link
Author

Volk3rJ commented May 30, 2024

@mcflugen - Thanks for taking a look at this. You are correct, my (Linux / WSL) environment is based on:

  • Python 3.12.3
  • pytest 8.1.1
  • bmi-tester 0.5.9

@mcflugen
Copy link
Member

@Volk3rJ Thanks. Both Python 3.12 and pytest v8 had some changes that may be causing this but I thought I had tested the tester with both of those versions. Anyway, I'll have a look and get back to you.

Actually, if it's not too much trouble, it would be helpful to see if the tester works for your case if you use Python<3.12 and pytest<8. No worries if you don't have time, I'll get to it (but not today, I'm afraid).

@Volk3rJ
Copy link
Author

Volk3rJ commented May 30, 2024

Yes, I can try that. I tested it with Python 3.11.9 already (but same pytest and bmi-tester versions as above) which didn't work either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants