Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error handling #107

Open
anishnaik opened this issue Mar 17, 2023 · 0 comments · May be fixed by #108
Open

Update error handling #107

anishnaik opened this issue Mar 17, 2023 · 0 comments · May be fixed by #108
Labels
on hold This issue was marked as not desirable to complete for now very-low-priority

Comments

@anishnaik
Copy link
Collaborator

Currently, we are using the in built error handling of go. The issue with this is that, by default, the errors do not come with stack traces which makes it harder to debug and triage any issues that might arise.

For this reason, we should move to pkg/errors that allows you to attach a stack trace at whatever point an error is introduced.

Fixing this issue should not be the final time that we revisit error handling. Down the line we should come up with a set of standardized errors and a set of guidelines on how to approach error handling, where to add additional context, where to attach the error stack, and so on.

@anishnaik anishnaik linked a pull request Mar 18, 2023 that will close this issue
@anishnaik anishnaik added on hold This issue was marked as not desirable to complete for now very-low-priority and removed enhancement labels Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold This issue was marked as not desirable to complete for now very-low-priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants